On Mon, 23 Nov 2009 16:37:27 +0200, Dmitri Vorobiev <dmitri.vorobiev@xxxxxxxxx> wrote: > >> > NAK, at least for txx9 parts. The struct mtd_partition arrays will be > >> > referenced by mtd map drivers via platform_data. > >> > >> You are right, thanks. What do you think about moving the variables to > >> file scope then? > > > > Well, why? Does it make any check-scripts or something happy? > > That's just looked somehow confusing to me that a variable defined in > the function scope was referenced from far outside this function, and > even when the function itself isn't valid anymore. Of course, there > are no technical disadvantage in that in itself. I see. But that's not so irregular case I think. And even if the variables are outside the function, it will not be obvious that it cannot be marked as __initdata. I agree that the code looks ugly and confusing, but moving it outside does not helps, I think. --- Atsushi Nemoto
