On Mon, Nov 23, 2009 at 10:26:09PM +0900, Atsushi Nemoto wrote:
> On Mon, 23 Nov 2009 13:53:37 +0200, Dmitri Vorobiev <dmitri.vorobiev@xxxxxxxxxx> wrote:
> > Several static uninitialized variables are used in the scope of
> > __init functions but are themselves not marked as __initdata.
> > This patch is to put those variables to where they belong and
> > to reduce the memory footprint a little bit.
> >
> > Also, a couple of lines with spaces instead of tabs were fixed.
> >
> > Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@xxxxxxxxxx>
> > ---
> > arch/mips/ar7/platform.c | 2 +-
> > arch/mips/sgi-ip22/ip22-eisa.c | 4 ++--
> > arch/mips/sgi-ip22/ip22-setup.c | 2 +-
> > arch/mips/sgi-ip32/ip32-setup.c | 2 +-
> > arch/mips/sni/setup.c | 2 +-
> > arch/mips/txx9/generic/setup.c | 2 +-
> > arch/mips/txx9/rbtx4939/setup.c | 4 ++--
> > 7 files changed, 9 insertions(+), 9 deletions(-)
>
> NAK, at least for txx9 parts. The struct mtd_partition arrays will be
> referenced by mtd map drivers via platform_data.
I'll drop the txx9 parts then.
> And for console option strings parts, I doubt these can be marked as
> __initdata. Theoretically, the console driver might be a module,
No; if the driver is a module we don't offer console functionality. Typical
example:
config SERIAL_8250
tristate "8250/16550 and compatible serial support"
select SERIAL_CORE
[...]
config SERIAL_8250_CONSOLE
bool "Console on 8250/16550 and compatible serial port"
depends on SERIAL_8250=y
select SERIAL_CORE_CONSOLE
I think we consistently do this for all console drivers.
Ralf
