On Mon, Nov 23, 2009 at 3:26 PM, Atsushi Nemoto <anemo@xxxxxxxxxxxxx> wrote: > On Mon, 23 Nov 2009 13:53:37 +0200, Dmitri Vorobiev <dmitri.vorobiev@xxxxxxxxxx> wrote: >> Several static uninitialized variables are used in the scope of >> __init functions but are themselves not marked as __initdata. >> This patch is to put those variables to where they belong and >> to reduce the memory footprint a little bit. >> >> Also, a couple of lines with spaces instead of tabs were fixed. >> >> Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@xxxxxxxxxx> >> --- >> arch/mips/ar7/platform.c | 2 +- >> arch/mips/sgi-ip22/ip22-eisa.c | 4 ++-- >> arch/mips/sgi-ip22/ip22-setup.c | 2 +- >> arch/mips/sgi-ip32/ip32-setup.c | 2 +- >> arch/mips/sni/setup.c | 2 +- >> arch/mips/txx9/generic/setup.c | 2 +- >> arch/mips/txx9/rbtx4939/setup.c | 4 ++-- >> 7 files changed, 9 insertions(+), 9 deletions(-) > > NAK, at least for txx9 parts. The struct mtd_partition arrays will be > referenced by mtd map drivers via platform_data. You are right, thanks. What do you think about moving the variables to file scope then? Dmitri > > And for console option strings parts, I doubt these can be marked as > __initdata. Theoretically, the console driver might be a module, > > --- > Atsushi Nemoto > >