On 13:06 Thu 09 Apr , yanhua wrote: > if (is_valid_irq(rtc_irq) && > - (!(rtc_control & RTC_24H) || (rtc_control & (RTC_DM_BINARY)))) { > + (!(rtc_control & RTC_24H) /*|| (rtc_control & (RTC_DM_BINARY))*/)) { Why not just remove this part "/*|| (rtc_control & (RTC_DM_BINARY))*/" ? > dev_dbg(dev, "only 24-hr BCD mode supported\n"); > retval = -ENXIO; > goto cleanup1; Zhang, Le