yanhua wrote:
> The original driver will exit when detect rtc binary mode. In fact both
> the binary mode and bcd are supported
[...]
> diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c
> index b6d35f5..85c327e 100644
> --- a/drivers/rtc/rtc-cmos.c
> +++ b/drivers/rtc/rtc-cmos.c
> @@ -757,7 +757,7 @@ cmos_do_probe(struct device *dev, struct resource
> *ports, int rtc_irq)
> * <asm-generic/rtc.h> doesn't know 12-hour mode either.
> */
> if (is_valid_irq(rtc_irq) &&
> - (!(rtc_control & RTC_24H) || (rtc_control & (RTC_DM_BINARY)))) {
> + (!(rtc_control & RTC_24H) /*|| (rtc_control & (RTC_DM_BINARY))*/)) {
> dev_dbg(dev, "only 24-hr BCD mode supported\n");
Perhaps the message should be changed too then...
> retval = -ENXIO;
> goto cleanup1;
WBR, Sergei
