Re: [PATCH v2] IDE: Fix platform device registration in Swarm IDE driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 29, 2008 at 01:51:30AM +0400, Sergei Shtylyov wrote:

>> +	{
>> +		.name	= "Swarm GenBus IDE",
>> +		.flags	= IORESOURCE_MEM,
>> +	}, {
>> +		.name	= "Swarm GenBus IDE",
>> +		.flags	= IORESOURCE_MEM,
>> +	}, {
>> +		.name	= "Swarm GenBus IDE",
>> +		.flags	= IORESOURCE_IRQ,
>> +		.start	= K_INT_GB_IDE,
>> +		.end	= K_INT_GB_IDE,
>>   
>
>   Giving the resources similar names is pointless. You can just leave  
> the 'name' field uninitialized.

I could - but I prefer things to have reasonable names in /proc/iomem or
wherever.  Unfortunately the IRQ resources name isn't yet being used to
for the interrupt but there's always something left to do :)

  Ralf


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux