On Wed, 17 Sep 2008 01:59:24 +0400, Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> wrote:
> > + unsigned int *table = hwif->dmatable_cpu;
> >
>
> s/unsigned int/__le32/ perhaps?
Yes. And __le64 would be much better.
> > + while (1) {
> > + cpu_to_le64s((u64 *)table);
> >
>
> Wait, PRD is already already in LE format, so this should be
> le64_to_cpus().
OK.
> > + if (*table & 0x80000000)
> >
>
> Hum... you don't have to check that with ide_build_dmatable()
> returning the PRD count...
Indeed. I'll do it. Thanks.
