On Tue, 09 Sep 2008 21:08:14 +0400, Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> wrote: > >>+#define TX4939IDE_BASE(hwif) ((hwif)->io_ports.data_addr & ~0xfff) > > > Why do you have void __iomem casts all over the write methods not in the > > _BASE() method - that would let sparse do its job properly > > I don't get why there's need for & at all -- isn't IDE data register > address always on 4K boundary? On little endian, yes. On big endian, this controller flips addr[2:0]. --- Atsushi Nemoto
