Re: [PATCH]: fix possible buffer overflow problem in promlib

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ralf Baechle wrote:
> On Fri, Jan 03, 2003 at 03:29:56PM +0100, Thiemo Seufer wrote:
> 
> > > > What about making ppbuf static, to reduce stack usage?
> > > 
> > > By the time when prom_printf() is called stack overflow is not really a
> > > consideration anymore, something fatal has happened before.
> > 
> > I don't think printing e.g. "LINUX started..." indicates something fatal. :-)
> 
> So use printk :-)

printk might not be ready at that time. I grepped the example from
arch/mips/mips-boards/generic/init.c, and there are some more
occurences in arch/mips which seem to be non-fatal.


Thiemo


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux