Re: [PATCH]: fix possible buffer overflow problem in promlib

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ralf Baechle wrote:
> On Thu, Jan 02, 2003 at 08:47:49PM +0100, Geert Uytterhoeven wrote:
> 
> > On 2 Jan 2003, Juan Quintela wrote:
> > >         as the issue about prom.h is still not clear, please aply the
> > >         trivial part.
> > 
> > >  void prom_printf(char *fmt, ...)
> > >  {
> > >  	va_list args;
> > > -	char ppbuf[1024];
> > > +	char ppbuf[BUFSIZE];
> > 
> > What about making ppbuf static, to reduce stack usage?
> 
> By the time when prom_printf() is called stack overflow is not really a
> consideration anymore, something fatal has happened before.

I don't think printing e.g. "LINUX started..." indicates something fatal. :-)


Thiemo


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux