On 08/16/2015 08:57 PM, Frank Schaefer wrote:
Regarding the placement of the driver, I'm actually kind of torn on this myself. Mainly because the driver includes hid-ids.h, which for some reason resides in drivers/hid instead of the more logical include/linux. I could obviously move things around and still include it as "../hid/hid-ids.h", although that feels wrong as well. I can do whichever you feel is the lesser of two evils; in the meantime, I'll focus on cleaning up and re-testing the code.
That depends on the hid maintainers, really. If an include file from the hid directory is needed, the driver should either reside there or the code should be reworked to not require it. Main problem I have with drivers outside their subsystem is that they are often not properly maintained, and they are often not reviewed by people who know the subsystem. That you copied lm-sensors with your patch is really the exception; most of the time that doesn't happen, and very often such drivers have problems or don't even work in the first place. But, again, that really depends on the hid maintainers. If the common hid approach is to have all hid drivers there, so be it. Guenter _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors