On Thu, Dec 4, 2014 at 1:08 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > On Thu, Dec 04, 2014 at 12:16:29PM -0800, Robert Coulson wrote: > > Hello Guenter, > > > > does it also make sense to include a check for the conf != 0 here (it > > should be set to 0 for POR from the datasheet)? Other than this > > quesiton/comment, the code looks fine to me. > > > Hi Rob, > > the configuration register could be set to a non-zero value, > for example by the BIOS or rommon. Sure, that is in theory possible > for the hysteresis and limit registers as well, but that would be > both unlikely and unreasonable. > > Thanks, > Guenter > Good points. Without explicit values for chip detection, it will never be guaranteed. I appreciate your feedback, *** Rob. Reviewed-by: <rob.coulson@xxxxxxxxx> _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
