Re: [PATCH 1/2] hwmon: (adcxx) Remove redundant spi_set_drvdata

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Acked-by: Marc Pignat <marc.pignat@xxxxxxx>

On 09/20/2013 06:06 AM, Sachin Kamat wrote:
> Driver core sets driver data to NULL upon failure or remove.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
> Cc: Marc Pignat <marc.pignat@xxxxxxx>
> ---
> compile tested.
> ---
>  drivers/hwmon/adcxx.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/hwmon/adcxx.c b/drivers/hwmon/adcxx.c
> index 751b1f0..04c08c2 100644
> --- a/drivers/hwmon/adcxx.c
> +++ b/drivers/hwmon/adcxx.c
> @@ -203,7 +203,6 @@ out_err:
>  	for (i--; i >= 0; i--)
>  		device_remove_file(&spi->dev, &ad_input[i].dev_attr);
>  
> -	spi_set_drvdata(spi, NULL);
>  	mutex_unlock(&adc->lock);
>  	return status;
>  }
> @@ -218,7 +217,6 @@ static int adcxx_remove(struct spi_device *spi)
>  	for (i = 0; i < 3 + adc->channels; i++)
>  		device_remove_file(&spi->dev, &ad_input[i].dev_attr);
>  
> -	spi_set_drvdata(spi, NULL);
>  	mutex_unlock(&adc->lock);
>  
>  	return 0;
> 

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux