Hi Uwe, On Sat, 11 Feb 2012 21:15:13 +0100, Uwe Kleine-König wrote: > On Fri, Feb 10, 2012 at 08:46:20PM +0100, Jean Delvare wrote: > > From the MC13892 datasheet: > > > > "TSX1 AND TSX2, TSY1 AND TSY2 (...) > > > > Touch Screen Interfaces X1 and X2, Y1 and Y2. The touch screen X plate > > is connected to TSX1 and TSX2, while the Y plate is connected to Y1 and > > Y2. **In inactive mode, these pins can also be used as general purpose > > ADC inputs.** They are respectively mapped on ADC channels 4, 5, 6, and > > 7. In interrupt mode, a voltage is applied to the X-plate (TSX2) via a > > weak current source to VCORE, while the Y-plate is connected to ground > > (TSY1)." > > > > So this doesn't seem to be fundamentally different from the MC13783, hm? > > Hmm, it seems you're right and either my memory doesn't serve me right > or I never understood it correctly. > > If you ask me it's OK to implement that when the first machine is using > that. I am working for someone who has such a machine. That was the reason why I asked. > And moreover I don't currently have a machine at hand with an > mc13892, so I couldn't test these inputs in an eventual v5 patch. > > Is it OK for you to take the patch as is, too? It is OK, but I would at least add a comment in the code to clarify. That being said, the fix seems to be as simple as moving 3 lines of code out of a conditional, so why not just do that? -- Jean Delvare _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
