Hi Jean,
On Fri, Feb 10, 2012 at 10:40:35AM +0100, Jean Delvare wrote:
> On Mon, 30 Jan 2012 16:57:58 +0100, Uwe Kleine-König wrote:
> > - if (!mc13783_adc_use_touchscreen(pdev)) {
> > - ret = sysfs_create_group(&pdev->dev.kobj, &mc13783_group_ts);
> > + if (id->driver_data & MC13783_ADC_16CHANS) {
> > + ret = sysfs_create_group(&pdev->dev.kobj,
> > + &mc13783_group_16chans);
> > if (ret)
> > - goto out_err_create2;
> > + goto out_err_create_16chans;
> > +
> > + if (!mc13783_adc_use_touchscreen(pdev)) {
> > + ret = sysfs_create_group(&pdev->dev.kobj,
> > + &mc13783_group_ts);
> > + if (ret)
> > + goto out_err_create_ts;
> > + }
> > }
>
> Hmm, this means that the touchscreen inputs are _never_ exposed for the
> MC13892, even though the documentation says these inputs exist on that
> chip. Is this an oversight, or is there a good reason to not expose
> these inputs on the MC13892?
No, that's correct. The mc13782's touchscreen inputs can be used for
touch (in that case they are not used in the mc13783-adc driver) or as
general purpose input (in which case mc13783_group_ts is used). For the
mc13892 the touch lines are dedicated for touch and there is no general
purpose functionallity, so on mc13892 mc13783_group_ts is never
instantiated.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
