Re: [PATCH v4] hwmon/mc13xxx-adc: add support for the MC13892 PMIC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Uwe,

On Mon, 30 Jan 2012 16:57:58 +0100, Uwe Kleine-König wrote:
> -	if (!mc13783_adc_use_touchscreen(pdev)) {
> -		ret = sysfs_create_group(&pdev->dev.kobj, &mc13783_group_ts);
> +	if (id->driver_data & MC13783_ADC_16CHANS) {
> +		ret = sysfs_create_group(&pdev->dev.kobj,
> +				&mc13783_group_16chans);
>  		if (ret)
> -			goto out_err_create2;
> +			goto out_err_create_16chans;
> +
> +		if (!mc13783_adc_use_touchscreen(pdev)) {
> +			ret = sysfs_create_group(&pdev->dev.kobj,
> +					&mc13783_group_ts);
> +			if (ret)
> +				goto out_err_create_ts;
> +		}
>  	}

Hmm, this means that the touchscreen inputs are _never_ exposed for the
MC13892, even though the documentation says these inputs exist on that
chip. Is this an oversight, or is there a good reason to not expose
these inputs on the MC13892?

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors



[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux