Re: [PATCH 4/4] hwmon: (f75375s) Let f75375_update_device treat pwmX as a measured value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2012-02-08 at 12:56 -0500, Nikolaus Schulz wrote:
> From: Nikolaus Schulz <schulz@xxxxxxxxxxx>
> 
> Treat pwmX as a measured value, not as a (mostly static) limit value, so
> that it is updated more frequently from the device register.
> 
> Signed-off-by: Nikolaus Schulz <mail@xxxxxxxxxxxxxx>
> ---
>  drivers/hwmon/f75375s.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/hwmon/f75375s.c b/drivers/hwmon/f75375s.c
> index 0aabaaf..f609b57 100644
> --- a/drivers/hwmon/f75375s.c
> +++ b/drivers/hwmon/f75375s.c
> @@ -200,9 +200,6 @@ static struct f75375_data *f75375_update_device(struct device *dev)
>  				f75375_read16(client, F75375_REG_FAN_MIN(nr));
>  			data->fan_target[nr] =
>  				f75375_read16(client, F75375_REG_FAN_EXP(nr));
> -			data->pwm[nr] =	f75375_read8(client,
> -				F75375_REG_FAN_PWM_DUTY(nr));
> -
>  		}
>  		for (nr = 0; nr < 4; nr++) {
>  			data->in_max[nr] =
> @@ -218,6 +215,8 @@ static struct f75375_data *f75375_update_device(struct device *dev)
>  	if (time_after(jiffies, data->last_updated + 2 * HZ)
>  		|| !data->valid) {
>  		for (nr = 0; nr < 2; nr++) {
> +			data->pwm[nr] =	f75375_read8(client,
> +				F75375_REG_FAN_PWM_DUTY(nr));
>  			/* assign MSB, therefore shift it by 8 bits */
>  			data->temp11[nr] =
>  				f75375_read8(client, F75375_REG_TEMP(nr)) << 8;

This also fixes a bug where pwm was not read at all if there is no
platform data. Doesn't apply to -stable, since support for automatic
startup (no platform data) was only added recently, but still ...

Thanks, applied.

Guenter



_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux