Re: [PATCH 3/4] hwmon: (f75375s) Fix bit shifting in f75375_write16

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2012-02-08 at 12:56 -0500, Nikolaus Schulz wrote:
> From: Nikolaus Schulz <schulz@xxxxxxxxxxx>
> 
> In order to extract the high byte of the 16-bit word, shift the word to
> the right, not to the left.
> 
> Signed-off-by: Nikolaus Schulz <mail@xxxxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxx
> ---
>  drivers/hwmon/f75375s.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/hwmon/f75375s.c b/drivers/hwmon/f75375s.c
> index b3eef44..0aabaaf 100644
> --- a/drivers/hwmon/f75375s.c
> +++ b/drivers/hwmon/f75375s.c
> @@ -172,7 +172,7 @@ static inline void f75375_write8(struct i2c_client *client, u8 reg,
>  static inline void f75375_write16(struct i2c_client *client, u8 reg,
>  		u16 value)
>  {
> -	int err = i2c_smbus_write_byte_data(client, reg, (value << 8));
> +	int err = i2c_smbus_write_byte_data(client, reg, (value >> 8));
>  	if (err)
>  		return;
>  	i2c_smbus_write_byte_data(client, reg + 1, (value & 0xFF));

Again, nice catch. A bit puzzling, though, that this wasn't caught
earlier.

Thanks, applied.

Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux