Re: [PATCH] hwmon: (coretemp) Document Atom E660 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 28 Sep 2011 18:54:58 +0530, R, Durgadoss wrote:
> > > 0x27 (Medfield Atom) and TjMax 90
> > 
> > I can add it, no problem. Is TjMax the same for all Medfield-based Atom
> > CPUs? If so, and if it can't be read from MSR_TEMPERATURE_TARGET, then
> > this value shouldn't go in the documentation file but in the driver,
> > unless the fragile heuristic we have already comes to that conclusion
> > (it's so complex that honestly I can't tell.)
> 
> Thanks Jean.
> Yes. It's the same for all Medfield based Atom products.
> And it cannot be read from MSR_TEMPERATURE_TARGET.
> So, we have to add the model name in the driver.
> Currently I have added a OR inside the 'if' in adjust_tjmax Function.
> 
> if (c->x86_model == 0x1c || c->x86_model == 0x27) {
> 
> This fetches me 90 and I have confirmed it with the Hardware folks here.

OK, I'll do this. What about model 0x26? Wouldn't 90°C be a better
default for them too?

And please tell your hardware friends to implement
MSR_TEMPERATURE_TARGET in future Atom product lines, it makes our life
so much easier...

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors



[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux