Re: Const buffers for SMBus/I2C block write functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Roman,

On Mon, 15 Nov 2010 15:14:18 +0100, Roman Fietze wrote:
> Hello List,

You're writing to the wrong list. I2C matters are discussed on the
linux-i2c list.

> 
> Wouldn't it help in some places, when the block write functions would
> take a const buffer pointer?

When you post again on linux-i2c, make sure you explain the actual
benefit of the change. "It would help in some places" isn't going to
fly, especially when you don't even seem to be sure.

> 
> Please see the diff below.
> 
> 
> Index: include/linux/i2c-dev.h
> ===================================================================
> --- include/linux/i2c-dev.h	(revision 5881)
> +++ include/linux/i2c-dev.h	(working copy)
> @@ -258,7 +258,7 @@
>  }
>  
>  static inline __s32 i2c_smbus_write_block_data(int file, __u8 command, 
> -                                               __u8 length, __u8 *values)
> +                                               __u8 length, const __u8 *values)
>  {
>  	union i2c_smbus_data data;
>  	int i;
> @@ -296,7 +296,7 @@
>  }
>  
>  static inline __s32 i2c_smbus_write_i2c_block_data(int file, __u8 command,
> -                                               __u8 length, __u8 *values)
> +                                               __u8 length, const __u8 *values)
>  {
>  	union i2c_smbus_data data;
>  	int i;
> 

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux