Re: [PATCH 1/2] intel medfield: thermal_driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 12 Nov 2010 06:57:03 -0800, Guenter Roeck wrote:
> On Fri, Nov 12, 2010 at 05:38:21AM -0500, Alan Cox wrote:
> > On Thu, 11 Nov 2010 12:56:54 -0800
> > Guenter Roeck <guenter.roeck@xxxxxxxxxxxx> wrote:
> > 
> > > On Thu, 2010-11-11 at 10:49 -0500, Alan Cox wrote:
> > > > From: Durgadoss <durgadoss.r@xxxxxxxxx>
> > > > 
> > > > This is the basic thermal sensor driver for Intel MID platform using the
> > > > Medfield chipset. It plugs in via the thermal drivers and provides sensor
> > > > readings for the device sensors.
> > > > 
> > > > Signed-off-by: Durgadoss R <durgadoss.r@xxxxxxxxx>
> > > > Signed-off-by: Alan Cox <alan@xxxxxxxxxxxxxxx>
> > > > ---
> > > > 
> > > As a thermal driver, shouldn't this driver be in drivers/thermal ?
> > 
> > drivers/thermal doesn't contain any drivers at all but I have no problem
> > with being there or hwmon - whichever is best.
> 
> So far, all thermal drivers, including the Intel Medfield driver, are in
> platform directories. Not sure if that is a good location either.
> drivers/thermal seems to be the natural place. That there are no drivers
> in drivers/thermal should not be a reason to move it elsewhere.
> One driver has to be the first, after all.
> 
> hwmon just doesn't seem right, since hwmon support for thermal devices is optional.
> 
> Jean, any opinion ?

I don't really have time to formulate an educated opinion, sorry. So
I'll trust you :)

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux