Re: [patch 32/36 v2] hwmon: (w83795) Move register reads to dedicated functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 28, 2010 at 10:47:57AM -0400, Jean Delvare wrote:
> Move initial register reads out of probe, to dedicated functions.
> This makes the code clearer, and will be needed if we want to delay
> calling these functions until they are needed, or want to call them
> periodically.
> 
> Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx>

Still not sure about the scope of lsb across loop iterations, but I have not been able
to create a failure case, nor did I find clear indication if is guaranteed (or not)
that its value will be kept across loop iterations. But since gcc doesn't complain,
I should not complain either without real evidence of wrongdoing ;).

Acked-by: Guenter Roeck <guenter.roeck@xxxxxxxxxxxx>


_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux