On Sun, Aug 12, 2007 at 01:13:52PM +0200, Jean Delvare wrote:
> Hi Christian,
>
> On Tue, 24 Jul 2007 15:43:28 +0200, Christian Hohnstaedt wrote:
> > On Tue, Jul 24, 2007 at 03:09:57PM +0200, Jean Delvare wrote:
> > > Good point. But what this means then is that LM75_TEMP_TO_REG() should
> > > take a long as a parameter rather than an int.
> >
> > Sounds reasonable.
> >
> > Then LM75_TEMP_FROM_REG() should also return a long instead of an int.
>
> This doesn't really matter. A long is needed for LM75_TEMP_TO_REG()
> because that's what simple_strtol() gives, but in the other direction,
> we use sprintf, which can handle both an int or a long.
I will keep the "static inline int LM75_TEMP_FROM_REG(u16 reg)" ,
because I don't want to change all the sprintf("%d") to sprintf("%ld").
What about w83627hf.c
return sprintf(buf,"%ld\n", \
(long)LM75_TEMP_FROM_REG(data->reg##_add[nr-2]));
?
>
> > Other drivers using LM75_TEMP_TO_REG:
> >
> > driver temp.type func
> > ------------------------------------
> > asb100.c long strtoul
> > ds1621.c direct strtoul
> > w83627e?hf.c u32 strtoul
> > w83781d.c s32 strtol
> >
> > Looks like there is some kind of general inconsistency :-)
>
> Indeed. Can you please send a patch fixing all the affected drivers?
I could, but I only can test the LM75 driver.
Christian Hohnstaedt
--
Christian Hohnstaedt
Software Engineer
Innominate Security Technologies AG /protecting industrial networks/
tel: +49.30.6392-3285 fax: +49.30.6392-3307
Albert-Einstein-Strasse 14, D-12489 Berlin, Germany
http://www.innominate.com
Register Court: AG Charlottenburg, HR B 81603
Management Board: Joachim Fietz, Dirk Seewald
Chairman of the Supervisory Board: Edward M. Stadum
