On Tue, Jul 24, 2007 at 02:06:04PM +0200, Jean Delvare wrote: > Hi Christian, > > On Tue, 24 Jul 2007 11:35:37 +0200, Christian Hohnstaedt wrote: > > writing values < 0?C to TLow and THigh of the LM75 is not > > supported by the driver, since it strtoul()s instead > > of strtol()ing. > > > > Trivial fix attached. > > Good catch, however your fix is not correct: > > > diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c > > index a40166f..4fa3220 100644 > > --- a/drivers/hwmon/lm75.c > > +++ b/drivers/hwmon/lm75.c > > @@ -95,7 +95,7 @@ static ssize_t set_temp(struct device *dev, struct device_attribute *da, > > struct i2c_client *client = to_i2c_client(dev); > > struct lm75_data *data = i2c_get_clientdata(client); > > int nr = attr->index; > > - unsigned long temp = simple_strtoul(buf, NULL, 10); > > + int temp = simple_strtol(buf, NULL, 10); > > > > mutex_lock(&data->update_lock); > > data->temp[nr] = LM75_TEMP_TO_REG(temp); > > temp should be a long rather than an int. Otherwise the input value > might wrap before LM75_TEMP_TO_REG has a chance to clamp it. Since LM75_TEMP_TO_REG() expects an int, I thought it would be best to make temp an int here, to reduce confusion. > > Your patch also lacks a Signed-off-by line (see > Documentation/SubmittingPatches, section 12.) Didn't expect to have to add it to this 10 char change :-) However, playing save is always good. > > Care to resend an updated patch? No, but I still think my fix is correct. Please confirm and I will send the patch with Signed-off-by line Christian Hohnstaedt -- Christian Hohnstaedt Software Engineer Innominate Security Technologies AG /protecting industrial networks/ tel: +49.30.6392-3285 fax: +49.30.6392-3307 Albert-Einstein-Strasse 14, D-12489 Berlin, Germany http://www.innominate.com Register Court: AG Charlottenburg, HR B 81603 Management Board: Joachim Fietz, Dirk Seewald Chairman of the Supervisory Board: Edward M. Stadum
