Hi Jean:
* Jean Delvare <khali at linux-fr.org> [2006-08-14 15:02:21 +0200]:
> if (kind != w83697hf) {
> if ((err = device_create_file(&new_client->dev,
> &dev_attr_in1_input))
> || (err = device_create_file(&new_client->dev,
> &dev_attr_in1_min))
> || (err = device_create_file(&new_client->dev,
> &dev_attr_in1_max)))
> goto ERROR4;
> }
>
> More concise and it works just as fine, doesn't it? Same applies below.
Agreed.
> Maybe you can also group the two (kind != w83697hf) blocks?
I already combined one (compared to original code)... so, yeah.
Regards,
--
Mark M. Hoffman
mhoffman at lightlink.com
