Dear MDS, Jean Did you ever receive my mail below sent on 2005-03-16 ? I do not get any response from you, I checked the sent mail just now, find that I sent it by "HTML" format, maybe it was blocked by your spam filter. I checked the lm_sensors CVS just now, find that the codes(please refer to the mail below) to fix the bug of negative fan measured value has not been added into w83792d.c. MDS, would you please fix it for me? Because I do not have a CVS account. You may test it first before you commit it into CVS. I find that the lm_sensors-2.9.1 will be released soon, I hope it will NOT contain this negative fan measured value bug. :-) As to the document doc\chips\w83792d, it still has NOT been finished, because I'm busy these days, I will send it to you as soon as possible when I finish it. Very sorry for the delay. As to the discussion on whether use "hardware-level" alarm mechanism or my "software-level" one, I want to keep my original codes, because after a compare and test to these two methods, I think my method is better(please refer to my related mails in this thread). If most of the users disagree about it in the future, we may fix it later. :-) Thanks Best Regards Chunhao 2005-03-26 ---------------- Sent on 2005-03-16 --------------------------------- Hi Jean, MDS > Sounds like an "interrupt mode" to me (as opposed to "comparator mode"). > The alarm bits raise on state change and wear off when read. In > comparator mode you would obtain what you'd expect (alarm bit always > reflecting the result of the comparison). > If the W83792D can be reprogramed in comparator mode AND this does NOT > affect any physical output, then just do that. If the alarm bits DO > affect an output, then you should not change the mode, which means that > you cannot use hardware alarms if the chip is in interrupt mode. Hm... very sorry that I do not catch what you said very well. How to reprogramed 792 driver in "comparator mode" instead of "interrupt mode"? Can we say that the method in submitted 792 driver is in "comparator mode"? Then I can keep my original codes? > Get a CVS snapshot here: > http://secure.netroedge.com/~lm78/archive/lm_sensors-daily.tar.gz > And provide a patch against that. If I need not fix the "point 1" MDS provided, The codes to fix "point 3" are very few. MDS, Would you please just add 4 lines into the "do...while (0)" loop of function w83792d_fan()? Just like this: 1013 if (((data->fan_div[nr])>=0x07 && 1014 (data->fan[nr])==0xff) || 1015 ((data->fan_div[nr])<=0 && 1016 (data->fan[nr])<0x78)) { 1017 results[1] = 0; 1018 break; 1019 } else if ((data->fan_div[nr])<0x07 && 1020 (data->fan[nr])==0xff) { 1021 (data->fan_div[nr])++; results[1] = FAN_FROM_REG(data->fan[nr], <--added by chunhao DIV_FROM_REG(data->fan_div[nr])); <--added by chunhao 1022 } else if ((data->fan_div[nr])>0 && 1023 (data->fan[nr])<0x78) { 1024 (data->fan_div[nr])--; results[1] = FAN_FROM_REG(data->fan[nr], <--added by chunhao DIV_FROM_REG(data->fan_div[nr])); <--added by chunhao 1025 } The minus fan measured value then will disappear from my system, would you please test it on your system? If it works too, please commit it for me. Thanks Best Regards Chunhao ===========================================================================================The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original author of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such person, please kindly reply the sender indicating accordingly and delete all copies of it from your computer and network server immediately. We thank you for your cooperation. It is advisable that any unauthorized use of confidential information of Winbond is strictly prohibited; and any information in this email that does not relate to the official business of Winbond shall be deemed as neither given nor endorsed by Winbond.===========================================================================================If your computer is unable to decode Chinese font, please ignore the following message. They essentially repea! t the English statement above.???H???????t?????q?l???]???????K?????T, ?????v???o?H?H???w?????H?H???\????. ?????z???D?Q???w?????H?H???]???????]?b???g???v?????????U???????H??, ???z?i?????o?H?H?????Y?N?H???q?q???P???????A???????H????. ?????z???X?@, ?????????P??. ?S??????, ???????g???v?????????????q?l?????K???T???????O?Q?Y???T????. ?H???P?????q?l???~?L???????e,???o?????????q?l?????????N??.
