w83792d_driver-1.0.1.patch: Winbond W83792D driver for linux-2.4 (patch to lm_sensors-2.9.0)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jean, MDS
 
> Sounds like an "interrupt mode" to me (as opposed to "comparator mode").
> The alarm bits raise on state change and wear off when read. In
> comparator mode you would obtain what you'd expect (alarm bit always
> reflecting the result of the comparison).

> If the W83792D can be reprogramed in comparator mode AND this does NOT
> affect any physical output, then just do that. If the alarm bits DO
> affect an output, then you should not change the mode, which means that
> you cannot use hardware alarms if the chip is in interrupt mode.

Hm... very sorry that I do not catch what you said very well. How to
reprogramed 792 driver in "comparator mode" instead of "interrupt mode"?
Can we say that the method in submitted 792 driver is in "comparator mode"?
Then I can keep my original codes?

> Get a CVS snapshot here:
> http://secure.netroedge.com/~lm78/archive/lm_sensors-daily.tar.gz
> And provide a patch against that.

If I need not fix the "point 1" MDS provided, The codes to fix "point 3" are
very few. 
 
MDS, Would you please just add 4 lines into the "do...while (0)" loop
of function w83792d_fan()? Just like this:

  1013     if (((data->fan_div[nr])>=0x07 &&
  1014      (data->fan[nr])==0xff) ||
  1015         ((data->fan_div[nr])<=0 &&
  1016      (data->fan[nr])<0x78)) {
  1017      results[1] = 0;
  1018      break;
  1019     } else if ((data->fan_div[nr])<0x07 &&
  1020       (data->fan[nr])==0xff) {
  1021      (data->fan_div[nr])++;
      results[1] = FAN_FROM_REG(data->fan[nr],  <--added by chunhao
      DIV_FROM_REG(data->fan_div[nr]));    <--added by chunhao
  1022     } else if ((data->fan_div[nr])>0 &&
  1023        (data->fan[nr])<0x78) {
  1024      (data->fan_div[nr])--;
        results[1] = FAN_FROM_REG(data->fan[nr],  <--added by chunhao
      DIV_FROM_REG(data->fan_div[nr]));    <--added by chunhao
  1025     }
 
The minus fan measured value then will disappear from my system, 
would you please test it on your system? If it works too, please commit it for me.
 
Thanks
Best Regards
 
Chunhao
 

===========================================================================================The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original author of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such person, please kindly reply the sender indicating accordingly and delete all copies of it from your computer and network server immediately. We thank you for your cooperation. It is advisable that any unauthorized use of confidential information of Winbond is strictly prohibited; and any information in this email that does not relate to the official business of Winbond shall be deemed as neither given nor endorsed by Winbond.===========================================================================================If your computer is unable to decode Chinese font, please ignore the following message. They essentially repea!
 t the&nbsp; English statement above.???H???????t?????q?l???]???????K?????T, ?????v???o?H?H???w?????H?H???\????. ?????z???D?Q???w?????H?H???]???????]?b???g???v?????????U???????H??, ???z?i?????o?H?H?????Y?N?H???q?q???P???????A???????H????. ?????z???X?@, ?????????P??. ?S??????, ???????g???v?????????????q?l?????K???T???????O?Q?Y???T????. ?H???P?????q?l???~?L???????e,???o?????????q?l?????????N??.



[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux