PATCH RFC fix adm1025 vid reporting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Grant,

> Is this what you after?  Against latest CVS lm_sensors2, let me know
> if  CVS wrong source, please.
> 
> Cheers.
> Grant.
> 
> --- lm_sensors2/lib/chips.c	2005-03-16 09:16:05.000000000 +1100
> +++ lm_sensors2x/lib/chips.c	2005-03-20 22:06:02.000000000 +1100
> @@ -1939,7 +1939,7 @@
>                           ADM9240_SYSCTL_TEMP, VALUE(1), 1,
>                           "temp1_max", 3 },
>  
>      { SENSORS_ADM9240_VID, "vid", NOMAP, NOMAP,
> -                         R, ADM9240_SYSCTL_VID, VALUE(1), 2, "in1_ref", 3 },
> +                         R, ADM9240_SYSCTL_VID, VALUE(1), 2, "cpu0_vid", 3 },
>      { SENSORS_ADM9240_FAN1_DIV, "fan1_div", SENSORS_ADM9240_FAN1, 
>                           NOMAP, RW, 
>                           ADM9240_SYSCTL_FAN_DIV, VALUE(1), 0 },
> @@ -2588,7 +2588,7 @@
>                           SENSORS_ADM1025_TEMP2, RW, 
>                           ADM1025_SYSCTL_TEMP, VALUE(1), 1 },
>      { SENSORS_ADM1025_VID, "vid", NOMAP, NOMAP,
> -                         R, ADM1025_SYSCTL_VID, VALUE(1), 3 , "in1_ref", 3 },
> +                         R, ADM1025_SYSCTL_VID, VALUE(1), 3 , "cpu0_vid", 3 },
>      { SENSORS_ADM1025_VRM, "vrm", NOMAP, NOMAP,
>                           RW, ADM1025_SYSCTL_VRM, VALUE(1), 1 },
>      { SENSORS_ADM1025_ALARMS, "alarms", NOMAP, NOMAP, 

That's almost it, except that this breaks compatibility for the adm1025
chip. Please leave "in1_ref" as the alternative sysfs file name (last
member of the structure). If you don't, then people with an ADM1025 chip
upgrading to lm_sensors 2.9.1 would also need to upgrade their kernel if
they don't want to lose VID, which is no good.

You might not find examples of entries using altsysname, but you can
look at the structure defintion in lib/data.h.

Thanks,
-- 
Jean Delvare



[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux