Bartlomiej Zolnierkiewicz wrote: >Hi, > >just a minor thing > > > >>+static int __devinit >>+mv64xxx_i2c_init(void) >>+{ >>+ return driver_register(&mv64xxx_i2c_driver); >>+} >> >> > >__init > > > >>+static void __devexit >>+mv64xxx_i2c_exit(void) >>+{ >>+ driver_unregister(&mv64xxx_i2c_driver); >>+ return; >>+} >> >> > >__exit > >these functions relate to module not device > Gahhh. Thanks Bartlomiej. Below is yet another replacement patch -- Marvell makes a line of host bridge for PPC and MIPS systems. On those bridges is an i2c controller. This patch adds the driver for that i2c controller. Please apply. Depends on patch submitted by Jean Delvare: http://archives.andrew.net.au/lm-sensors/msg29405.html Signed-off-by: Mark A. Greer <mgreer at mvista.com> -- -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: i2c_8.patch Url: http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20050208/569c4c21/attachment.pl