Hi, just a minor thing > +static int __devinit > +mv64xxx_i2c_init(void) > +{ > + return driver_register(&mv64xxx_i2c_driver); > +} __init > +static void __devexit > +mv64xxx_i2c_exit(void) > +{ > + driver_unregister(&mv64xxx_i2c_driver); > + return; > +} __exit these functions relate to module not device > +module_init(mv64xxx_i2c_init); > +module_exit(mv64xxx_i2c_exit);