ISA check

khali at linux-fr.org (Jean Delvare) · Sat, 27 Sep 2003 12:29:42 +0200

Hi all,

In many (all?) of our i2c-only drivers, we have the following:

#ifdef DEBUG
   if (i2c_is_isa_adapter(adapter)) {
       printk
           ("lm75.o: lm75_detect called for an ISA bus adapter?!?\n");
       return 0;
   }
#endif

What's the idea? If the ISA addresses list is empty, is there a way we
could be called for an ISA adapter anyway? And in that case, shouldn't
we consider that the user knows what he/she's doing?

If the danger is real, then that check shouldn't be ifdef'd.

Thanks.

-- 
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/