On 11/16/18 5:04 PM, Qing Zhao wrote: > >> On Nov 16, 2018, at 9:26 AM, Martin Liška <mliska@xxxxxxx <mailto:mliska@xxxxxxx>> wrote: >> >> On 11/16/18 2:36 AM, Qing Zhao wrote: >>> Hi, >>> >>> this is the new version of the patch. >>> >>> I have bootstrapped it on both aarch64 and x86, no regression. >>> >>> please take a look. >> >> Thanks for the updated version of the patch. >> I have last small nits I see: >> >> - gcc/common.opt: when running --help=common, the line is too long > > the following is the output for ./gcc —help=common: > -flive-patching Same as -flive-patching=. Use the latter option > instead. > -flive-patching=[inline-only-static|inline-clone] Control IPA optimizations > to provide a safe compilation for live-patching. > At the same time, provides multiple-level control > on the enabled IPA optimizations. > > Not sure what’s you mean of “the line is too long”? could you please specify the above which line? You are probably using a console that has quite small column limit, so that you see it automatically wrapped. I see: ... -flimit-function-alignment This option lacks documentation. -flive-patching Same as -flive-patching=. Use the latter option instead. -flive-patching=[inline-only-static|inline-clone] Control IPA optimizations to provide a safe compilation for live-patching. At the same time, provides multiple-level control on the enabled IPA optimizations. ^--- the long line -flive-range-shrinkage Relief of register pressure through live range shrinkage. -floop-block Enable loop nest transforms. Same as -floop-nest-optimize. Same as -floop-nest-optimize. ... > >> - gcc/doc/invoke.texi - 2 spaces in between sentences + better gol >> - gcc/opts.c - do not mix spaces + tabs > > I have used contrib/check_GNU_style.sh to check the patch, I did see one place that complains about 2 spaces in between sentences, fixed it. I see it: === ERROR type #3: dot, space, space, new sentence (3 error(s)) === gcc/common.opt:2190:62:optimizations to provide a safe compilation for live-patching.█At the same gcc/doc/invoke.texi:9291:14:optimizations.█For example, inlining a function into its caller, cloning gcc/doc/invoke.texi:9297:37:impacted functions for each function.█In order to control the number of > but I didn’t see spaces + tabs mix issue with the script. could you please specify? This is a new check that I've just installed: === ERROR type #1: a space should not precede a tab (1 error(s)) === gcc/opts.c:2350:0: ████████control_optimizations_for_live_patching (opts, opts_set, Martin > > thanks. > > Qing > * > * >
