On Wed 2018-10-17 13:35:19, Josh Poimboeuf wrote: > I'm having trouble parsing the subject. How about: > > Allow unloading of patches added after using 'force' ok > > --- a/kernel/livepatch/core.c > > +++ b/kernel/livepatch/core.c > > @@ -45,7 +45,8 @@ > > */ > > DEFINE_MUTEX(klp_mutex); > > > > -static LIST_HEAD(klp_patches); > > +/* Registered patches */ > > +LIST_HEAD(klp_patches); > > Instead of making this non-static, can we just move > klp_force_transition() to core.c? It's nice to have all the list > management code encapsulated in the same file. Come on! We need it just to iterate over a list of available livepatches. The logic used to manage this list is trivial. klp_force_transition() itself is more complicated and it logically fits into transitions.c. I do not want to fight over this. If you resist, I'll move it. I just wanted to share my view. Best Regards, Petr
