Hi Josh, I wanted to test Miroslav's "livepatch: Introduce signal and force sysfs attributes" series and merged his patches on top of this morning's Linus tree. When attempting to unload the livepatch-sample.ko, I noticed that it held an outstanding reference even after disabling the livepatch. This prevented me from unloading the livepatch module. I ran through a git bisect, which led me to 11af847446ed x86/unwind: Rename unwinder config options to 'CONFIG_UNWINDER_*'", which was a bit confusing, but I think this was where 'make oldconfig' started enabling the ORC unwinder for me. To verify, I tested Linus HEAD with both CONFIG_UNWINDER_FRAME_POINTER and then with CONFIG_UNWINDER_ORC. Here's what happens with CONFIG_UNWINDER_FRAME_POINTER: % git describe HEAD v4.14-9248-ge60e1ee60630 % grep UNWIND .config # CONFIG_UNWINDER_ORC is not set CONFIG_UNWINDER_FRAME_POINTER=y % insmod samples/livepatch/livepatch-sample.ko % lsmod | grep livepatch livepatch_sample 16384 1 % echo 0 > /sys/kernel/livepatch/livepatch_sample/enabled % cat /sys/kernel/livepatch/livepatch_sample/enabled 0 % cat /sys/kernel/livepatch/livepatch_sample/transition 0 % lsmod | grep livepatch livepatch_sample 16384 0 but when I attempt the same with CONFIG_UNWINDER_ORC, there remains an outstanding reference on livepatch_sample that prevents me from unloading the module: % git describe HEAD v4.14-9248-ge60e1ee60630 % grep UNWIND .config CONFIG_UNWINDER_ORC=y # CONFIG_UNWINDER_FRAME_POINTER is not set % insmod samples/livepatch/livepatch-sample.ko % lsmod | grep livepatch livepatch_sample 16384 1 % echo 0 > /sys/kernel/livepatch/livepatch_sample/enabled % cat /sys/kernel/livepatch/livepatch_sample/enabled 0 % cat /sys/kernel/livepatch/livepatch_sample/transition 0 % lsmod | grep livepatch livepatch_sample 16384 1 I don't know if this is a mid-merge-window quirk or perhaps a .config error on my part? Any chance you can repro? -- Joe -- To unsubscribe from this list: send the line "unsubscribe live-patching" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
