On Tue, Aug 27, 2024 at 07:44:23AM -0700, Darrick J. Wong wrote:
> On Tue, Aug 27, 2024 at 05:12:41AM -0700, Christoph Hellwig wrote:
> > On Tue, Aug 27, 2024 at 01:50:22PM +0200, cem@xxxxxxxxxx wrote:
> > > + struct xfs_attrlist_cursor cur = { };
> > > + char attrbuf[XFS_XATTR_LIST_MAX];
> > > + struct attrlist *attrlist = (struct attrlist *)attrbuf;
> >
> > Not really changed by this patch, but XFS_XATTR_LIST_MAX feels pretty
> > large for an on-stack allocation. Maybe this should use a dynamic
> > allocation, which would also remove the need for the cast?
> >
> > Same in few other spots.
>
> Yeah, the name list buffer here and in scrub could also be reduced
> in size to 4k or something like that. Long ago the attrlist ioctl had a
> bug in it where it would loop forever, which is why scrub allocated such
> a huge buffer to try to avoid falling into that trap. But that was
> ~2017, those kernels should have been retired or patched by now.
One nice thing about the dynamic allocation is that we can get rid
of the silly char buffer and the casting..
