On Tue, Aug 27, 2024 at 01:50:22PM +0200, cem@xxxxxxxxxx wrote: > + struct xfs_attrlist_cursor cur = { }; > + char attrbuf[XFS_XATTR_LIST_MAX]; > + struct attrlist *attrlist = (struct attrlist *)attrbuf; Not really changed by this patch, but XFS_XATTR_LIST_MAX feels pretty large for an on-stack allocation. Maybe this should use a dynamic allocation, which would also remove the need for the cast? Same in few other spots. Not really something to worry about for this patch, so: Reviewed-by: Christoph Hellwig <hch@xxxxxx>