On Tue, Aug 27, 2024 at 07:41:12AM -0700, Darrick J. Wong wrote: > Hmm. Here you're changing function signatures for a public library. > attrlist_cursor and xfs_attrlist_cursor are the same object, but I > wonder if this is going to cause downstream compilation errors for > programs that include libattr but not xfs_fs.h? Oh, I forgot that jdm.h is public. Yes, this will cause the compiler to complain, so we can't do that.