On Tue, Aug 27, 2024 at 05:16:47AM GMT, Christoph Hellwig wrote: > > */ > > + > > #define ATTR_ENTRY(buffer, index) \ > > Spurious whitespace change. > > > ((struct xfs_attrlist_ent *) \ > > &((char *)buffer)[ ((struct xfs_attrlist *)(buffer))->al_offset[index] ]) > > > > +/* Attr flags used within xfsprogs, must match the definitions from libattr */ > > +#define ATTR_ROOT 0x0002 /* use root namespace attributes in op */ > > +#define ATTR_SECURE 0x0008 /* use security namespaces attributes in op */ > > Why do we need these vs just using XFS_ATTR_ROOT/XFS_ATTR_SECURE from > xfs_da_format.h? Because I didn't see XFS_ATTR_ROOT and XFS_ATTR_SECURE exists :) I'll take a look on it, and if we don't really need to define ATTR_ROOT/SECURE, I'll just keep ATTR_ENTRY locally to fsprops.h, we don't need a header file for just a single definition IMO. > > > + struct xfs_attrlist *attrlist = (struct xfs_attrlist *)attrbuf; > > Overly long line. Ok, Thanks! Carlos
