> */ > + > #define ATTR_ENTRY(buffer, index) \ Spurious whitespace change. > ((struct xfs_attrlist_ent *) \ > &((char *)buffer)[ ((struct xfs_attrlist *)(buffer))->al_offset[index] ]) > > +/* Attr flags used within xfsprogs, must match the definitions from libattr */ > +#define ATTR_ROOT 0x0002 /* use root namespace attributes in op */ > +#define ATTR_SECURE 0x0008 /* use security namespaces attributes in op */ Why do we need these vs just using XFS_ATTR_ROOT/XFS_ATTR_SECURE from xfs_da_format.h? > + struct xfs_attrlist *attrlist = (struct xfs_attrlist *)attrbuf; Overly long line.
