> + xfs_ino_t ino = NULLFSINO; > + > + switch (type) { > + case XFS_DQTYPE_USER: > + ino = mp->m_sb.sb_uquotino; > + break; > + case XFS_DQTYPE_GROUP: > + ino = mp->m_sb.sb_gquotino; > + break; > + case XFS_DQTYPE_PROJ: > + ino = mp->m_sb.sb_pquotino; > + break; > + default: > + ASSERT(0); > + return -EFSCORRUPTED; > + } I'd probably split this type to ino lookup into a separate helper, but that doesn't really matter. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>