On Thu, Aug 22, 2024 at 05:02:25PM -0700, Darrick J. Wong wrote: > +static inline bool xfs_sb_version_hasmetadir(const struct xfs_sb *sbp) > +{ > + return (XFS_SB_VERSION_NUM(sbp) == XFS_SB_VERSION_5) && This is copy and paste from the other xfs_sb_version_* helpers, but there really is no need for the braces here. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>