On Thu, Aug 22, 2024 at 05:02:56PM -0700, Darrick J. Wong wrote: > +#include "xfs_da_format.h" > +#include "xfs_dir2.h" > +#include "xfs_metafile.h" Hmm, there really should be no need to include xfs_da_format.h before metafile.h - enum xfs_metafile_type is in format.h and I can't see what else would need it. I don't think dir2.h is needed here either. Otherwise this looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
