On 7/22/24 10:05 AM, Eric Sandeen wrote:
On 7/22/24 9:41 AM, Christoph Hellwig wrote:
On Fri, Jul 19, 2024 at 05:48:53PM -0500, Eric Sandeen wrote:
xfs_attr_sethash(args);
- return xfs_attr_set(args, op, args->attr_filter & XFS_ATTR_ROOT);
+ rsvd = args->attr_filter & (XFS_ATTR_ROOT | XFS_ATTR_SECURE);
+ return xfs_attr_set(args, op, rsvd);
This looks fine, although I'd probably do without the extra local
variable. More importantly though, please write a comment documenting
why we are dipping into the reserved pool here. We should have had that
since the beginning, but this is a better time than never.
Ok, I thought the local var was a little prettier but *shrug* can do it
either way.
To be honest I'm not sure why it was done for ROOT; dchinnner mentioned
something about DMAPI requirements, long ago...
The older Data Mover Framework (DMF v6) kept an extended attribute that
denoted the file status (online/offline/partial online) and some region
information (which was never used). Yeah DMF uses Data Management API
(DMAPI) as the hooks to move data in when offline.
It seems reasonable, and it's been there forever but also not obviously
required, AFAICT.
What would your explanation be? ;)
Thanks,
-Eric
