On Fri, Jul 19, 2024 at 05:48:53PM -0500, Eric Sandeen wrote: > xfs_attr_sethash(args); > > - return xfs_attr_set(args, op, args->attr_filter & XFS_ATTR_ROOT); > + rsvd = args->attr_filter & (XFS_ATTR_ROOT | XFS_ATTR_SECURE); > + return xfs_attr_set(args, op, rsvd); This looks fine, although I'd probably do without the extra local variable. More importantly though, please write a comment documenting why we are dipping into the reserved pool here. We should have had that since the beginning, but this is a better time than never.