On 7/22/24 9:41 AM, Christoph Hellwig wrote: > On Fri, Jul 19, 2024 at 05:48:53PM -0500, Eric Sandeen wrote: >> xfs_attr_sethash(args); >> >> - return xfs_attr_set(args, op, args->attr_filter & XFS_ATTR_ROOT); >> + rsvd = args->attr_filter & (XFS_ATTR_ROOT | XFS_ATTR_SECURE); >> + return xfs_attr_set(args, op, rsvd); > > This looks fine, although I'd probably do without the extra local > variable. More importantly though, please write a comment documenting > why we are dipping into the reserved pool here. We should have had that > since the beginning, but this is a better time than never. > > Ok, I thought the local var was a little prettier but *shrug* can do it either way. To be honest I'm not sure why it was done for ROOT; dchinnner mentioned something about DMAPI requirements, long ago... It seems reasonable, and it's been there forever but also not obviously required, AFAICT. What would your explanation be? ;) Thanks, -Eric
