> +extern int xlog_print_trans_xmi(char **ptr, uint src_len, int continued); > +extern void xlog_recover_print_xmi(struct xlog_recover_item *item); > +extern int xlog_print_trans_xmd(char **ptr, uint len); > +extern void xlog_recover_print_xmd(struct xlog_recover_item *item); Drop the pointless externs here. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>