On Tue, Jul 02, 2024 at 07:11:54AM +0200, Christoph Hellwig wrote: > > +extern int xlog_print_trans_xmi(char **ptr, uint src_len, int continued); > > +extern void xlog_recover_print_xmi(struct xlog_recover_item *item); > > +extern int xlog_print_trans_xmd(char **ptr, uint len); > > +extern void xlog_recover_print_xmd(struct xlog_recover_item *item); > > Drop the pointless externs here. Done. > Otherwise looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thanks! --D