Re: [PATCH 07/12] xfs_fsr: convert to bulkstat v5 ioctls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +			if (lseek(file_fd->fd, outmap[extent].bmv_length, SEEK_CUR) < 0) {
>  				fsrprintf(_("could not lseek in file: %s : %s\n"),

Maybe avoid the overly long lines here?

> -int	read_fd_bmap(int fd, struct xfs_bstat *sin, int *cur_nextents)
> +int	read_fd_bmap(int fd, struct xfs_bulkstat *sin, int *cur_nextents)

Maybe fix the weird formatting here while you're at it?

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux