On Tue, Mar 19, 2024 at 12:37:09AM -0700, Christoph Hellwig wrote: > On Tue, Mar 19, 2024 at 09:46:00AM +1100, Dave Chinner wrote: > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > The count is used purely to allocate the correct number of bvecs for > > submitting IO. Rename it to b_bvec_count. > > Well, I think we should just kill it as it simplies is the rounded > up length in PAGE_SIZE units. The patch below passes a quick xfstests > run and is on top of this series: This seems like a reasonable approach - fixing the mm_account_reclaimed_pages() issues earlier in the patch set meant I'd already done the xfs_buf_free() changes you made here. :) That just leaves the vmap wrappers to be fixed up - I think I'll just replace the b_folio_count rename patch with that cleanup... -Dave. -- Dave Chinner david@xxxxxxxxxxxxx
