On Tue, Mar 19, 2024 at 04:06:28PM -0700, Christoph Hellwig wrote: > Is there much of a good reason to do this now vs oing it whenverer > we actually sort out i_version semantics? It adds size to the inode > and I don't see how the atomics actually cost us much. The patch > itself does looks good, though. I'm kinda with Darrick on this - yes, it burns an extra 8 bytes per inode, but it doesn't leave us exposed to someone misusing the inode->i_version field. I also don't like the idea of leaving the disablement half done - that just makes it more work for whoever comes later to do something with this again... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx